google / adb-sync

Apache License 2.0
1.08k stars 171 forks source link

adb-sync: fix timestr format #45

Closed msfjarvis closed 4 years ago

msfjarvis commented 4 years ago

Without this touch always fails with errors similar to touch: invalid date '20191202.122549'.

At least on Android R DP4, the help for touch says the format with -t must be [[CC]YY]MMDDhhmm[.ss][frac], which means the period must go after hours and minutes, not before. This fixes adb-sync --times for me.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

msfjarvis commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

msfjarvis commented 4 years ago

This is never being merged.