search

google / addlicense

A program which ensures source code files have copyright license headers by scanning directory patterns recursively
Apache License 2.0
716 stars 169 forks source link

Only log skipped files in verbose mode #112

Closed talal closed 2 years ago

talal commented 2 years ago

This PR changes the default behavior of logging all skipped files to instead logging the skipped files only in verbose mode (with -v flag).

Motivation

When a ton of files are skipped (e.g. -ignore vendor/**) then the output of addlicense becomes quite verbose and the actual output which we are interested in, i.e. which files were modified or which files are missing license info when -check is used, gets buried in between the skipping log lines.

P.S. I have also updated the usage instructions in the README with the up-to-date flag information as per addlicense --help.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

talal commented 2 years ago

@willnorris can you have a look at the PR? I have already signed the CLA.

Feel free to close it, if you don't want to change the app behavior :)

braydonk commented 2 years ago

+1 for this! Really hope this gets merged :crossed_fingers:

willnorris commented 2 years ago

Sorry, I missed seeing this when it was originally submitted, but yeah this seems totally reasonable.