Closed crazy-max closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Same as in #88, could you rebase this, and then add f.hcl
here. No need for the testdata files.
@willnorris Oh and do I delete test files or I keep them for now?
@willnorris Oh and do I delete test files or I keep them for now?
either is fine. They'll get removed when all the others do.
Merging #87 (de3e38f) into master (b431030) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 46.98% 46.98%
=======================================
Files 2 2
Lines 232 232
=======================================
Hits 109 109
Misses 116 116
Partials 7 7
Impacted Files | Coverage Δ | |
---|---|---|
main.go | 38.94% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b431030...de3e38f. Read the comment docs.
Signed-off-by: CrazyMax google@crazymax.dev