google / addlicense

A program which ensures source code files have copyright license headers by scanning directory patterns recursively
Apache License 2.0
724 stars 170 forks source link

Add hcl extension #87

Closed crazy-max closed 3 years ago

crazy-max commented 3 years ago

Signed-off-by: CrazyMax google@crazymax.dev

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

crazy-max commented 3 years ago

@googlebot I signed it!

willnorris commented 3 years ago

Same as in #88, could you rebase this, and then add f.hcl here. No need for the testdata files.

crazy-max commented 3 years ago

@willnorris

could you rebase this, and then add f.hcl here. No need for the testdata files.

Done.

crazy-max commented 3 years ago

@willnorris Oh and do I delete test files or I keep them for now?

willnorris commented 3 years ago

@willnorris Oh and do I delete test files or I keep them for now?

either is fine. They'll get removed when all the others do.

codecov-commenter commented 3 years ago

Codecov Report

Merging #87 (de3e38f) into master (b431030) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   46.98%   46.98%           
=======================================
  Files           2        2           
  Lines         232      232           
=======================================
  Hits          109      109           
  Misses        116      116           
  Partials        7        7           
Impacted Files Coverage Δ
main.go 38.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b431030...de3e38f. Read the comment docs.