What version is the first release?

[willnorris]

83 adds support for publishing pre-built artifacts and docker image when git tags are pushed. The question now is, what version is the first tagged release? Is it v0.0.1, v0.1.0 or v1.0.0 ?

As @crazy-max noted in #83, we definitely want to follow semver on subsequent releases, but because there never has been a previous release, there are no real constraints on whether this is considered a v0 or v1 release.

Personally, I'm leaning toward v1.0.0. The tool has been around for a while and is quite stable. And it is also widely enough adopted by major projects (etcd, opentelemetry, kubeflow, kubernetes, ossf/scorecard among many others) that we need to treat the current API as stable, regardless of the lack of a formal v1.0 release.

@mco-gh what do you think?

[mco-gh]

I agree, v1.0.0 makes more sense to me than v0 given the history and current use.

On Tue, 10 Aug 2021 at 00:39, Will Norris @.***> wrote:

83 https://github.com/google/addlicense/pull/83 adds support for

publishing pre-built artifacts and docker image when git tags are pushed. The question now is, what version is the first tagged release? Is it v0.0.1, v0.1.0 or v1.0.0 ?

As @crazy-max https://github.com/crazy-max noted in #83 https://github.com/google/addlicense/pull/83, we definitely want to follow semver on subsequent releases, but because there never has been a previous release, there are no real constraints on whether this is considered a v0 or v1 release.

Personally, I'm leaning toward v1.0.0. The tool has been around for a while and is quite stable. And it is also widely enough adopted by major projects (etcd https://github.com/etcd-io/etcd/blob/2d059d77a8e765bf4d35b06fa35b0859294d672e/test.sh#L480, opentelemetry https://github.com/open-telemetry/opentelemetry-collector/blob/b336d3df8b9d483c1e07e4bc216d788289da7e9d/Makefile#L119, kubeflow https://github.com/kubeflow/pipelines/blob/d9c019641ef9ebd78db60cdb78ea29b0d9933008/tools/tools.go#L9, kubernetes https://github.com/kubernetes-sigs/application/blob/c8e2959e57a02b3877b394984a288f9178977d8b/Makefile#L169, ossf/scorecard https://github.com/ossf/scorecard/blob/ef9880c7b3710eafed6dcafa95d6dd0e958e12bf/.github/workflows/main.yml#L71 among many others) that we need to treat the current API as stable, regardless of the lack of a formal v1.0 release.

@mco-gh https://github.com/mco-gh what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/addlicense/issues/89, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFAXF23M5IUIWQXYBGG53LT4BRKVANCNFSM5B3AIYIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Marc Cohen Web: mco.dev Email: @.*** Working with me: mco.dev/working-with-marc Feedback: How am I doing? Provide anonymous feedback! https://www.increment.me/feedback/049628fd-7339-406d-9203-17d3ec8976bd/submit

Q: Why is this email three sentences or less? A: three.sentenc.es

[crazy-max]

I'm leaning toward v1.0.0

SGTM

[willnorris]

done: https://github.com/google/addlicense/releases/tag/v1.0.0