Closed developer-guy closed 2 years ago
would you mind assigning to us if you agree with this idea 🙋🏻♂️
kindly ping @willnorris
Could you do this with the existing -check
flag, which should return a non-zero status code if headers are missing ?
ah thank you, we missed that flag 🤦🏻♂️
It sounds like -check
will work for you, so I'm going to go ahead and close this. Feel free to reopen if it turns out that doesn't work.
We (w/@dentrax) thought that in scenarios such as checking license headers, we use addlicence tool like the following way:
As you can see from the above GitHub Action definition, we use additional git commands to check that is there any leaked license headers in the codebase, so, what we are proposing is that we add this logic into addlicence tool with an additional flag-like
--fail-on-diff
.