google / ads-privacy

Apache License 2.0
301 stars 52 forks source link

Better alignment of topics in openrtb with IAB SDA spec and existing practice #61

Closed patmmccann closed 2 years ago

patmmccann commented 2 years ago

The alignment with IAB proposed in the doc had a few flaws, segtax is an enum, user.data.id is not used, user.data.name is. Many parties will be transmitting per these changes imminently, except that classifier version will be omitted. user.data.ext.segclass seems like a fine place for classifier version, but the string 'class' doesn't need to be part of both the key and the value, eg 'segclass': 'class_v1'.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

sbelov commented 2 years ago

Thank you for the suggestion; aligning with Segment Taxonomies certainly sounds a plausible option to ease the adoption! Would you be willing to sending a follow up pull request to also modify the initial proposal?

patmmccann commented 2 years ago

I would be happy to, I put the proposal in the open questions section so as be less controversial. I'd be happy to move it up.

patmmccann commented 2 years ago

@sbelov do the changes in the latest commit reflect you request or did you want me to do a PR on the section at the top as well? Should this merge and changes to the top be a different pr?

sbelov commented 2 years ago

@sbelov do the changes in the latest commit reflect you request or did you want me to do a PR on the section at the top as well? Should this merge and changes to the top be a different pr?

The current commit seems reasonable; just a couple more nits. Once we merge this in, I can also follow up with updating the version at the top of this document (or feel free to, if you'd like).

patmmccann commented 2 years ago

@sbelov thanks very much, I think recent commits addressed your feedback.

sbelov commented 2 years ago

thank you, @patmmccann, for this change!