search

google / agera

Reactive Programming for Android
Apache License 2.0
7.2k stars 639 forks source link

Sample doesn't build, is this project dead? #172

Open kenstir opened 5 years ago

kenstir commented 5 years ago

Just picked up this library and started trying out the codelabs at https://codelabs.developers.google.com/codelabs/android-agera/#13

The project does not build in (nearly) current Android Studio 3.2.1 with gradle warnings, such as:

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

and build failures such as

Execution failed for task ':app:processDebugResources'.
> Android resource linking failed
  Output:  W/ResourceType(11468): For resource 0x0101053d, entry index(1341) is beyond type entryCount(1320)
  W/ResourceType(11468): For resource 0x0101053e, entry index(1342) is beyond type entryCount(1320)
  W/ResourceType(11468): For resource 0x0101053b, entry index(1339) is beyond type entryCount(1320)
  W/ResourceType(11468): For resource 0x0101053c, entry index(1340) is beyond type entryCount(1320)
  D:\src\samples\android-agera\app\src\main\res\layout\step2.xml:18: error: attribute orientation (aka com.example.android.codelabs.agera:orientation) not found.

Just want to make sure there is some life here before devoting my time to reviving that is only mostly dead.

maxtroy commented 5 years ago

Apologies for not keeping the build structure up to date. We've been happily using the code in production with no improvements necessary, which leads to the seeming neglect of this project. Please allow us some time to upgrade the build toolchain.

kenstir commented 5 years ago

Thanks for the response. I tried to update the gradle infrastructure to gradle 4 in the hopes of submitting a PR, but I just do not know enough gradle to do it. Now I am stuck on Cannot create variant 'android-aidl' after configuration ':agera:debugApiElements' has been resolved

It's probably not helpful, but I pushed my gradle changes to https://github.com/kenstir/agera/commit/0003b1b0da6be962ca308aede3d8e6fbc0491f38

kenstir commented 5 years ago

Hello, just a friendly reminder that the sample still does not build. At least, no changes have been submitted recently. Any chance you could help me get the sample to build?

maxtroy commented 5 years ago

I have this WIP commit which seems to build fine, but at least the tests in "rvdatabinding" are failing.

If you don't need "rvdatabinding", feel free to patch that commit and try out the samples.

kenstir commented 5 years ago

Hey thank you very much for this! Very much appreciated. Almost everything built except I could not sync the project until I reordered the repositories, and it did not run without warnings until I set targetSdkVersion. I filed https://github.com/maxtroy/agera/pull/5

maxtroy commented 5 years ago

@ernstsson do you have any luck to get rvdatabinding tests to run successfully? Or maybe temporarily disable those tests and check in the rest of the fix? :)

Zhuinden commented 4 years ago
  1. Overview ATTENTION: This codelab has been deprecated in favor of Using Kotlin Coroutines in your Android > app. Please continue there.

Well it seems to be fully dead 🤔

I really hate how they just flat-out remove deprecated codelabs. What if I'm working with legacy software? Jeez.