google / aiyprojects-raspbian

API libraries, samples, and system images for AIY Projects (Voice Kit and Vision Kit)
https://aiyprojects.withgoogle.com/
Apache License 2.0
1.61k stars 692 forks source link

Change add_stylesheet to add_css_file #738

Open jaydeetay opened 3 years ago

jaydeetay commented 3 years ago

...as the former was deprecated in Sphinx 1.8.

Reference: https://www.sphinx-doc.org/en/master/extdev/appapi.html?highlight=add_css#sphinx.application.Sphinx.add_css_file

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jaydeetay commented 3 years ago

@googlebot I'm a Googler!

jaydeetay commented 3 years ago

Thanks Scott. Is there something else that needs to happen before this can be merged?

scottamain commented 3 years ago

Sorry John, I've since learned we're currently not able to take contributions in this repo. But I can make the corresponding change with our internal repo and it'll get cloned here. So thanks for spotting this and sharing the fix!

jaydeetay commented 3 years ago

No problem - sorry to cause such noise for such a small change - I just noticed that the docs for one Python module were missing and thought I'd try to figure out why. I have another PR out to fix the issue (though I'm not really happy with it if someone has a better alternative). If it helps, I could try sending changes to our internal repo.

On Tue, Jun 8, 2021 at 11:27 PM Scott Main @.***> wrote:

Sorry John, I've since learned we're currently not able to take contributions in this repo. But I can make the corresponding change with our internal repo and it'll get cloned here. So thanks for spotting this and sharing the fix!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/aiyprojects-raspbian/pull/738#issuecomment-857343078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5LWCZKO4QYNKWBETXDATTTR3NSPANCNFSM46GVUBJQ .