search

google / amber

Amber is a multi-API shader test framework
Apache License 2.0
188 stars 63 forks source link

Add device feature "IndexTypeUint8Features.indexTypeUint8" #1031

Closed pdaniell-nv closed 10 months ago

pdaniell-nv commented 10 months ago

This is required for this upcoming Vulkan CTS change: https://gerrit.khronos.org/c/vk-gl-cts/+/12422

dj2 commented 10 months ago

Looks like the linter isn't happy:

src/script.cc:133:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

Though, you may need to add a // NOLINTNEXTLINE(whitespace/line_length) on the line prior as that line might not be shortenable.

pdaniell-nv commented 10 months ago

Looks like the linter isn't happy:

src/script.cc:133:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

Thanks for the heads up. I've tweaked the change slightly to avoid hitting this issue.

dj2 commented 10 months ago

Thanks a lot for the patch.