search

google / amber

Amber is a multi-API shader test framework
Apache License 2.0
193 stars 65 forks source link

Add DEVICE_PROPERTY support #1034

Closed archimedus closed 4 months ago

archimedus commented 6 months ago

For certain cases device properties need to be checked same way as device features. For example VK_KHR_shader_float_controls extension have a set of fields (DenormPreserve) that are available in VkPhysicalDeviceFloatControlsProperties. Amber does not allow these to be checked and also does not have appropriate syntax for checking properties. This pull request adds both.

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

archimedus commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I don't get it: I don't have google account. What should I do?

dj2 commented 6 months ago

I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA.

archimedus commented 6 months ago

I don't believe you need a google account. In order to accept the contribution you'll need to go to https://cla.developers.google.com/ and sign the CLA.

Thank you for quick reply.

I skim briefly through the page and find nothing more useful.

I scrolled down and click "Manage your agreements" at bottom and ... alas "Please login to google."

Any other thoughts?

dj2 commented 6 months ago

Yea, turns out I was wrong, from the FAQ on that page A Google account is required to sign the CLA. As far as I can see, there is no way to sign the CLA without one, and without a signed CLA we are unable to accept the PR.

dj2 commented 5 months ago

The code looks good to me. Once the CLA is sorted out I think this is good to go.

dj2 commented 4 months ago

kokoro:run

archimedus commented 4 months ago

kokoro:run

dj2 commented 4 months ago

Something has gone strange with the bots and they're failing to compile in, it looks like, swiftshader? I'm going to put up a CL and see if I can figure out what's gone wrong.

dj2 commented 4 months ago

I'm still working on the bots. Needs to have dependencies updated but getting all of them to the right versions is proving difficult. https://github.com/google/amber/pull/1037 is my work in progress CL, but that needs a change to SwiftShader so it can work with a newer SPIRV-Tools.

dj2 commented 4 months ago

Ok, if you can rebase this on top of main, I fixed up the various bot issues and got a green build and landed it.

archimedus commented 4 months ago

kokoro:run