search

google / amber

Amber is a multi-API shader test framework
Apache License 2.0
193 stars 65 forks source link

Roll dependencies #956

Closed asuonpaa closed 3 years ago

asuonpaa commented 3 years ago

Rolling dependencies introduced new warnings but no errors:

[193/405] Building CXX object third_party/glslang/glslang/CMakeFiles/MachineIndependent.dir/MachineIndependent/attribute.cpp.o
../third_party/glslang/glslang/MachineIndependent/attribute.cpp: In member function ‘void glslang::TParseContext::handleFunctionAttributes(const glslang::TSourceLoc&, const TAttributes&, glslang::TFunction*)’:
../third_party/glslang/glslang/MachineIndependent/attribute.cpp:350:111: warning: unused parameter ‘function’ [-Wunused-parameter]
  350 | void TParseContext::handleFunctionAttributes(const TSourceLoc& loc, const TAttributes& attributes, TFunction* function)
      |                                                                                                    ~~~~~~~~~~~^~~~~~~~
[198/405] Building CXX object third_party/glslang/glslang/CMakeFiles/MachineIndependent.dir/MachineIndependent/Constant.cpp.o
../third_party/glslang/glslang/MachineIndependent/Constant.cpp: In member function ‘virtual glslang::TIntermTyped* glslang::TIntermConstantUnion::fold(glslang::TOperator, const glslang::TType&) const’:
../third_party/glslang/glslang/MachineIndependent/Constant.cpp:534:59: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  534 |                                 unionArray[i].getIConst() == 0x80000000
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
[282/405] Building CXX object third_party/glslang/SPIRV/CMakeFiles/SPIRV.dir/GlslangToSpv.cpp.o
../third_party/glslang/SPIRV/GlslangToSpv.cpp: In member function ‘virtual bool {anonymous}::TGlslangToSpvTraverser::visitAggregate(glslang::TVisit, glslang::TIntermAggregate*)’:
../third_party/glslang/SPIRV/GlslangToSpv.cpp:3380:31: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<TIntermNode*, glslang::pool_allocator<TIntermNode*> >::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
 3380 |             for (int i = 0; i < glslangOperands.size(); ++i) {
asuonpaa commented 3 years ago

I've disabled warnings as errors for MSVC when building Vulkan validation layers. Should we instead fix the warnings and wait for them to be merged before proceeding with this?

Also should I separate the fix for one of the Amber tests as this has nothing to do with the dependencies?