Allow AmberScript to define the number of control points used by tessellation

google / amber

Amber is a multi-API shader test framework

Apache License 2.0

193 stars 65 forks source link

Allow AmberScript to define the number of control points used by tessellation #963

Closed asuonpaa closed 3 years ago

asuonpaa commented 3 years ago

Previously only VkScript had the access to set the number of patch control points. Now this can also be set in AmberScript pipeline settings.

asuonpaa commented 3 years ago

Not sure what's going on with Windows CI builds. The last commit only touches the documentation and the previous commit passed all the checks.

ben-clayton commented 3 years ago

The error is:

-- Installing SPIRV-Header
CMake Error at third_party/vulkan-headers/CMakeLists.txt:21 (cmake_minimum_required):
  CMake 3.10.2 or higher is required.  You are running version 3.10.1

It looks like this project uses a VM from a 'dynamic' pool. Maybe the VM image changed. My group maintain a VM image that we control (and likely has more up-to-date toolchains). I'll take a look at migrating this project over to using that.

ben-clayton commented 3 years ago

All fixed.