search

google / amber

Amber is a multi-API shader test framework
Apache License 2.0
188 stars 63 forks source link

Add support for multisample resolve #970

Closed asuonpaa closed 2 years ago

asuonpaa commented 2 years ago

Multisample images were already supported, but graphics pipelines were not able to resolve these into single sample images.

paulthomson commented 2 years ago 
[1472/1501] Building CXX object src/vulkan/CMakeFiles/libamberenginevulkan.dir/frame_buffer.cc.o
FAILED: src/vulkan/CMakeFiles/libamberenginevulkan.dir/frame_buffer.cc.o
/bin/clang-10.0.0/bin/clang++  -DAMBER_CTS_VULKAN_HEADER=0 -DAMBER_ENABLE_CLSPV=0 -DAMBER_ENABLE_DXC=0 -DAMBER_ENABLE_LODEPNG=1 -DAMBER_ENABLE_RTTI=0 -DAMBER_ENABLE_SHADERC=1 -DAMBER_ENABLE_SPIRV_TOOLS=1 -DAMBER_ENABLE_VK_DEBUGGING=1 -DAMBER_ENGINE_DAWN=0 -DAMBER_ENGINE_VULKAN=1 -I../include -I../ -I../third_party/spirv-tools/include -I. -I../third_party/vulkan-headers/include -I../third_party/cppdap/include -g -fPIC   -fno-exceptions -fvisibility=hidden -Wall -Werror -Wextra -Wno-padded -Wno-switch-enum -Wno-unknown-pragmas -pedantic-errors -fno-rtti -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-format-pedantic -Wno-unknown-warning-option -Weverything -Wno-zero-as-null-pointer-constant -std=gnu++14 -MD -MT src/vulkan/CMakeFiles/libamberenginevulkan.dir/frame_buffer.cc.o -MF src/vulkan/CMakeFiles/libamberenginevulkan.dir/frame_buffer.cc.o.d -o src/vulkan/CMakeFiles/libamberenginevulkan.dir/frame_buffer.cc.o -c ../src/vulkan/frame_buffer.cc
../src/vulkan/frame_buffer.cc:38:7: error: field 'depth_stencil_attachment_' will be initialized after field 'resolve_targets_' [-Werror,-Wreorder-ctor]
      depth_stencil_attachment_(depth_stencil_attachment),
      ^
1 error generated.