search

google / amber

Amber is a multi-API shader test framework
Apache License 2.0
193 stars 65 forks source link

Check error return when pushing descriptors #980

Closed gnl21 closed 2 years ago

gnl21 commented 2 years ago

Pipeline::SendDescriptorDataToDeviceIfNeeded was not checking the error return when initializing transfer buffers, which can lead to later code attempting to use invalid buffers and crashing.

gnl21 commented 2 years ago

@paulthomson is there a process for getting this PR reviewed? It's causing problems for us in the Vulkan CTS. Thanks.

paulthomson commented 2 years ago

Sorry, I missed this. Just merging main into your branch now, and then I can merge.

gnl21 commented 2 years ago

Great. No problem. Thanks.