google / android-emulator-webrtc

Apache License 2.0
121 stars 27 forks source link

Added binary to js_out in protoc parameters #16

Closed DanWinc closed 3 years ago

DanWinc commented 3 years ago

Added binary to js_out in protoc call in Makefile

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

DanWinc commented 3 years ago

@googlebot I signed it!

pokowaka commented 3 years ago

Thank you!

GilbertNordhammar commented 3 years ago

So should we merge this? As far as I understand, this change is needed for the build to be complete