search

google / android-emulator-webrtc

Apache License 2.0
121 stars 27 forks source link

Fix missing remote candidates #19

Closed scottjasso closed 2 years ago

scottjasso commented 2 years ago

I think this was just a typo. Once there's a peerConnection created, the code ignored all new remote candidates, breaking trickle ice.

daisyliu618 commented 2 years ago

Hi @pokowaka can you kindly review and approve this PR. We found the typo and tested with the code changes. Thanks a lot~

pokowaka commented 2 years ago

Let me bump the version number, otherwise we will not auto publish

pokowaka commented 2 years ago

The version number has been bumped and pushed to npm (https://www.npmjs.com/package/android-emulator-webrtc?activeTab=readme) 1.0.16 will have your fix.

daisyliu618 commented 2 years ago

Thank you~!