google / android-emulator-webrtc

Apache License 2.0
120 stars 26 forks source link

Missing TypeScript type definitions #42

Open muvaf opened 1 month ago

muvaf commented 1 month ago

Getting the following when used in a TypeScript project:

 Try `npm i --save-dev @types/android-emulator-webrtc` if it exists or add a new declaration (.d.ts) file containing `declare module 'android-emulator-webrtc/emulator';`

I see that there is a function called PrintTypescriptFile here but looks like its result is not included in the npm package.

muvaf commented 1 month ago

I built with make succesfully in Ubuntu 22.04 and then changed the import_style parameter in Makefile to trigger running of PrintTypescriptFile. But I'm getting the following error:

protoc \
        -I/usr/local/include -I/android-emulator-webrtc/src/proto/ -I/android-emulator-webrtc/proto \
        --plugin=protoc-gen-grpc-web=/android-emulator-webrtc/protoc-gen-grpc-web \
        --js_out=import_style=typescript,binary:/android-emulator-webrtc/src/proto/ \
        --grpc-web_out=import_style=typescript,mode=grpcwebtext:/android-emulator-webrtc/src/proto/ \
        /android-emulator-webrtc/proto/emulator_controller.proto
python eslint_prefix.py /android-emulator-webrtc/src/proto//emulator_controller_pb.js
Traceback (most recent call last):
  File "/android-emulator-webrtc/eslint_prefix.py", line 37, in <module>
    main(sys.argv)
  File "/android-emulator-webrtc/eslint_prefix.py", line 28, in main
    with open(fname, 'r') as fn:
FileNotFoundError: [Errno 2] No such file or directory: '/android-emulator-webrtc/src/proto//emulator_controller_pb.js'
make: *** [Makefile:76: /android-emulator-webrtc/src/proto//emulator_controller_pb.js] Error 1

This is inside a ubuntu:22.04 container where I installed libprotoc-dev protobuf-compiler curl pkg-config g++ python3 and NodeJS.