google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
463 stars 241 forks source link

Ux testing build #1668

Closed santosh-pingle closed 1 year ago

santosh-pingle commented 1 year ago

Describe the Issue

Would you like to work on the issue?

santosh-pingle commented 1 year ago

@shelaghm Below is the recorded video which was captured on questionnaire json which was shared by you. This questionnaire is not modified yet. This video is just for your reference.

https://user-images.githubusercontent.com/86107848/196122498-c18a5ec7-b28d-48be-b783-3698fedb27da.mov

santosh-pingle commented 1 year ago

Prefix is missing from given questionnaire form. I am adding number prefix to every question item. e.g 1. 2. 3. ...

=> Modifying questionnaire json.

santosh-pingle commented 1 year ago

Sdc module is not able to render the instructions from shared questionnaire form. It is required to edit the shared questionnaire form to update the instructions as per instructions code.

Attaching screenshots for reference

Screen Shot 2022-10-17 at 1 45 39 PM

=> Modifying questionnaire json.

santosh-pingle commented 1 year ago

For Q.2 and Q.3 app get crashed, as these question has type quantity and uses min and max extension, where it throws exception java.lang.IllegalArgumentException: Cannot compare different data types: Quantity and integer at com.google.android.fhir.MoreTypesKt.compareTo(MoreTypes.kt:49)

Integer type is updated for Q.2, Q.3

santosh-pingle commented 1 year ago

@jingtang10

santosh-pingle commented 1 year ago

Action item : Q5(What city does the client live in?) to use the "Autocomplete" widget => Modifying questionnaire json.

santosh-pingle commented 1 year ago

Action item : Q11 to be the "slider" widget. => Modifying questionnaire json.

santosh-pingle commented 1 year ago

@shelaghm Would you like to add instructions to instruct the user to input the value in the range of 1900 -2022 for question "What year were they born?"

Screen Shot 2022-10-17 at 5 19 56 PM
santosh-pingle commented 1 year ago

@shelaghm Would you like to modify below instructions

santosh-pingle commented 1 year ago

Q. 9 "Does the client have any of the following symptoms?" is not rendered as open choice view. => modifying extension in questionnaire json.

shelaghm commented 1 year ago

@shelaghm Would you like to add instructions to instruct the user to input the value in the range of 1900 -2022 for question "What year were they born?"

Screen Shot 2022-10-17 at 5 19 56 PM

@santosh-pingle Good find. Yes, please add instructions Enter a year between 1900 and 2022

shelaghm commented 1 year ago

@shelaghm Would you like to modify below instructions

  • Type the name “Orange Flower” => Type the name e.g “Orange Flower”
  • Type the phone number “98 87 76 65 => Type the phone number e.g “98 87 76 65"
  • Select 4 May 2020 => e.g 4 May 2020

@santosh-pingle leave these instructions as is. For this specific usability test we want participants to enter these specific names and numbers, so they don't accidentally enter anyone's real names or phone number

shelaghm commented 1 year ago

@santosh-pingle can you also make it a paginated questionnaire? Thank you!

Tarun-Bhardwaj commented 1 year ago

@santosh-pingle , is this issue only for tracking testing effort or does it include any development as well?

santosh-pingle commented 1 year ago

@Tarun-Bhardwaj Questionnaire json changes are only for ux testing build, these changes will not be part of sdc code repository.

santosh-pingle commented 1 year ago

can you also make it a paginated questionnaire? Thank you!

@shelaghm I will make changes to support the paginated layout as well.

santosh-pingle commented 1 year ago

@shelaghm shared ux testing build which supports questionnaire in default and pagination layout.

shelaghm commented 1 year ago

amazing, thanks so much @santosh-pingle

santosh-pingle commented 1 year ago

Ux testing build is delivered, so closing the ticket.