Open FikriMilano opened 1 year ago
@f-odhiambo @jingtang10
This ticket is not ready for development yet
My main concern is when submitting Questionnaire, the answers will get too big because of the multi attachments, which will cause the app to crash.
Perhaps we need some changes when submitting a Questionnaire, if it's too big, then process it in small parts
In the past we have encountered this problem in FHIRCore as well, since it's not SDK, there's no way to change the process when submitting a Questionnaire.
But here in SDK, I hope we can address this first, before going forward with this ticket
EDIT: Moved to this ticket https://github.com/google/android-fhir/issues/1858
Summary from earlier discussion, we can put the base64 encoded file into one of the mentioned FHIR resource below, and append the link into the Attachment Url.
Binary resource Heavy load on the database, because files may be large. May not be feasible for super large files e.g. video.
DocumentReference resource Can be located outside of database, which reduce the heavy load on the database. May need another endpoint to sync files into server.
@jingtang10 @f-odhiambo @dubdabasoduba @aditya-07
@jingtang10 does it makes sense to also have max file size for the SDK? I don't think we want to allow people to upload GBs of data.
@dubdabasoduba yeah, we have the maxSize merged https://github.com/google/android-fhir/pull/1688
hey @FikriMilano what needs to be done in this ticket
@jingtang10
Another note before we start on this ticket: We need to make sure the app won't crash because of OOM when processing the files/images on submission, currently we are reading the bytes of the file and pass it to the answer, which I don't think the app can handle well.
I think we need to solve ticket https://github.com/google/android-fhir/issues/1858 first before we start w this one.
Is your feature request related to a problem? Please describe. The current Attachment widget is only able to handle single attachment.
Describe the solution you'd like Update Attachment widget to be able to handle multi attachment.
Describe alternatives you've considered N/A
Additional context
Would you like to work on the issue? Limited bandwidth, feel free to assign someone