Open FikriMilano opened 1 year ago
quoting from @jingtang10
add a new style to allow customization of item media discuss with shelaghm the default look and feel (especially where it is positioned in relation to other components in a question, and the size and alignment etc) of the item media in different components
@FikriMilano can you remind me what aspects of itemMedia needs to be customized? What kind of guidance can I provide to help with this?
Off the top of my mind is
full width
vs standard padding @shelaghm you can give some thoughts about what customization makes sense or is commonly used. then I can try to support these for itemMedia.
For context, make sure to refer to the discussion here as well: https://github.com/google/android-fhir/pull/1377#discussion_r1107547535
There're some mocks in that discussion that's worth taking a look at.
Attaching some screenshots with suggestions.
question title and instructions
. The two other options are before question title and instructions
or between question title and instructions
. @shelaghm woah, looks awesome!
I'll support these customization for itemMedia.
@khyativyasargus
@FikriMilano Is there still open items to complete?
@fredhersch yeah, all the above mentioned items mentioned by @shelaghm and me. This ticket is not started yet. cc @f-odhiambo
Is your feature request related to a problem? Please describe. Currently itemMedia is not customizable, implementers don't have a way let's say to: position the image on the left or center or right side of the screen, change image dimension, etc.
Describe the solution you'd like Add styling attributes for itemMedia, decides the default look and ensure the styling supports possibilities of customization.
Describe alternatives you've considered N/A
Additional context quoting from @jingtang10
Would you like to work on the issue? N/A