google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
485 stars 288 forks source link

[IgManager] PlanDefinitionProcessor doesn't resolve the PlanDefinition from IgManager #1920

Open ktarasenko opened 1 year ago

ktarasenko commented 1 year ago

Describe the bug PlanDefinitionProcessor looks up local resources by local Id (and calls fhirDal.read()) assuming that the PlanDefinition is located at the same local server. PlanDefinitionProcessor assuming the same for ActivityDefinition

Component IgManager

To Reproduce check this commit https://github.com/google/android-fhir/commit/a8bfa4978e736d5d38706cc81adb881bab7fd56d

Expected behavior PlanDefinitionProcessor can work with both local and absolute IDs, distinguishes them properly.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Would you like to work on the issue? Please state if this issue should be assigned to you or who you think could help to solve this issue.

ktarasenko commented 1 year ago

this has been fixed on the evaluator side. Migration to the new repository API is needed to use the fix