google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
465 stars 246 forks source link

[SDC] Move help button location to after question title #1965

Open shelaghm opened 1 year ago

shelaghm commented 1 year ago

Problem Current help button is located after instructions field, which looks awkward if there's no instructions text

Describe the solution you'd like EmCare implementation moved the help button to be located after the question title.

Describe alternatives you've considered Could make this configurable, but don't think it is necessary at this time.

Additional context EmCare commit https://github.com/google/android-fhir/commit/c130243616a9c355e8e3b5a9f25673e817769336

Screenshot

Screenshot 2023-04-12 at 14 47 25

cc @santosh-pingle @kunjan8794 @khyativyasargus @jingtang10

santosh-pingle commented 1 year ago

@kunjan8794 @khyativyasargus I see corresponding commit of your repository https://github.com/google/android-fhir/commit/c130243616a9c355e8e3b5a9f25673e817769336 Are you going to create PR corresponding to main repository android fhir sdk? Or you want me to look into it? cc @jingtang10

khyativyasargus commented 1 year ago

@santosh-pingle Sure. We will create PR for this in main repository.

santosh-pingle commented 1 year ago

@khyativyasargus thanks!, is there any approximate date by which we can expect the pull request?

khyativyasargus commented 1 year ago

@santosh-pingle Yes, You can expect all PRs done by 24th April, Monday. Let me know if it's needed before that. Thanks!