search

google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
479 stars 258 forks source link

Write tests for "click" in view holder factories #218

Closed joiskash closed 1 year ago

joiskash commented 3 years ago

"click" event has to be tested for widgets like the date picker, drop down etc.

joiskash commented 3 years ago

Initially reported by @jingtang10 here

s-ayush2903 commented 3 years ago

How exactly is the "click" supposed to be unit-tested? If it were an instrumentation test then we could verify the nature of click via seeing if the corresponding dropdown occurs or not, but how is it going to be unit tested? Can you please throw some light on it, it would be very kind of you, thanks

jingtang10 commented 3 years ago

Thanks @s-ayush2903. I've updated the title of the issue. Will you be interested in taking this issue?

s-ayush2903 commented 3 years ago

Yes, definitely. But I have a question, our automated testing architecture would be a/c to what, I mean we would be using espresso or UI automator along with robot pattern?

jingtang10 commented 3 years ago

Yes I think we would be using espresso and/or UI automator. Will you be able to do some research and create a draft PR please?

s-ayush2903 commented 3 years ago

Yes

s-ayush2903 commented 3 years ago

@jingtang10 Should I create the PR asap or wait for #294 to be merged, as if it gets merged in the middle of the test PR, then there'll be a lot of conflicts in the testing PR.

jingtang10 commented 3 years ago

Please don't wait as that PR hasn't been approved yet. Also it's only a reformatting PR so although it will cause conflicts it should be easy to resolve. If you're rebasing please just make sure that you're using the version on your own branch and ignore the master's HEAD. that way the only thing you have to do after rebasing is to rerun ./gradlew spotlessApply. I hope this makes sense.

jingtang10 commented 3 years ago

is there more progress on this? thanks!

s-ayush2903 commented 3 years ago

Moving it up in my list :+1:

jingtang10 commented 3 years ago

"click" event has to be tested for widgets like the date picker, drop down etc.

more work to address these issues in the first comment.

jingtang10 commented 3 years ago

we need to test the click event for the date picker and date time picker still.

s-ayush2903 commented 3 years ago

Same comment as https://github.com/google/android-fhir/issues/184#issuecomment-838597080

Anshul-9923 commented 2 years ago

@jingtang10 I would like to work on 2 remaining tasks of https://github.com/google/android-fhir/issues/107. Can you please assign it to me?

jingtang10 commented 2 years ago

Sorry. That issue is obsolete.

Anshul-9923 commented 2 years ago

Ok @jingtang10 , Sir can you please assign me this issue?

vj-codes commented 1 year ago

@Tarun-Bhardwaj hey is this issue still valid?

omarismail94 commented 1 year ago

Just cleaning things up. Closing this as our androidTests inclide clicking