search

google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
489 stars 289 forks source link

All contributors have to be able to see functional test logs for PRs on the Firebase UI #2218

Open vorburger opened 1 year ago

vorburger commented 1 year ago

As-is right now, only "Googlers" can see the results (logs, and UI; example) of the many great functional UI tests which this project already has in its codebase in this Git repo and which Google runs "internally" for this project, using https://firebase.google.com/docs/test-lab.

This is not "open source community friendly" from a "theoretical" point of view; but more practically, this is a hindrance to better engage community contributions - it's hard(er) [than it should be] for contributors to work on Pull Requests for bug fixes and new features if they cannot see why their UI tests fail.

How we can solve this isn't entirely clear yet. I volunteer to investigate this a bit more, and document what I learn about this here.

@jingtang10 @omarismail94 this is to track what we chat today; /Cc @fredhersch FYI.

vorburger commented 1 year ago

OK so I tried adding the allUsers GCP Principal (or allAuthenticatedUsers) where needed, but:

Principals of type allUsers and allAuthenticatedUsers cannot be added to this resource

@jingtang10 @omarismail94 I'll keep digging...

vorburger commented 1 year ago

To be sure that this is not a "Google internal restriction", I have also created a Firebase Test Lab project on my personal private home consumer GCP account, but it has shows the same message, so this isn't just an "Org Policy" type restriction, but appears to be a restriction built-into Firebase Test Lab?

vorburger commented 1 year ago

I have internally reached out to some people to see if it's possible to find a solution for this.