Closed dubdabasoduba closed 2 months ago
Thanks Benjamin, This seems to be correctly captured. @aditya-07 To take over from here!
@dubdabasoduba @f-odhiambo @ndegwamartin can you please propose someone to work on this? thanks!
@jingtang10 @aditya-07 in the context of this change, had a few points for clarification.
FhirEngine.purge
and the Database.purge
as deprecated or should we overload the method?Based on earlier discussions:
FhirEngine.purge
and modified Database.purge
since has access modifier internal
which is reused by the FhirEngine overloads.PR linked here https://github.com/google/android-fhir/pull/2462 . We can iterate on any feedback
Since the plan is to iterate through the list of IDs in the Database. Purge, how should we handle cases where the processing of individual IDs fails? i.e. should we let the ones that pass the checks purge successfully or should we consider processing the whole list as a transaction?
@ndegwamartin I think we should let the resources that pass the checks purge successfully. We can ensure the SDK reports the resources that failed to purge so the implementing apps know how to handle the failures.
@dubdabasoduba after the conversation today we've agreed to wrap the whole batch list processing logic in a transaction. Thus if any item fails it throws an IllegalStateException
. cc @MJ1998
Is your feature request related to a problem? Please describe.
Describe the solution you'd like