Update dokka version, fix knowledge task

williamito commented 3 months ago

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2237

Description Update dokka version, add missing configuration code to knowledge doc task.

Alternative(s) considered

Type Choose one: Bug fix

Screenshots (if applicable)

Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

vorburger commented 3 months ago

@williamito thanks for this! Before we merge this, give me a few days to "test" this - I'll try something to build on top of my recent #2460 and #2461, to actually runs this, not locally, but directly on GitHub, hopefully some time in the next few days.

jingtang10 commented 3 months ago

ok @vorburger i've disabled auto merge. but i'm fine with this being merged. so please feel free to.

vorburger commented 3 months ago

ok @vorburger i've disabled auto merge. but i'm fine with this being merged. so please feel free to.

I've now tested this as part of working on #2483 and seen that it works great, so I'm merging; thanks @williamito !

vorburger commented 3 months ago

This fails to auto-merge due to #2485. Either #2486 (if the team agrees) or a "real" fix of that problem will unblock it.

This is holding up #2483.

google / android-fhir

Update dokka version, fix knowledge task #2463