google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
458 stars 238 forks source link

Flaky QuestionnaireUiEspressoTest$dateTimePicker_shouldSetAnswerWhenDateAndTimeAreFilled has 12/24h problem #2485

Closed vorburger closed 2 months ago

vorburger commented 2 months ago

Describe the bug

A new flaky test is slowing down development velocity on unrelated work; this and this ran into:

expected: 2005-01-05T06:10 but was : 2005-01-05T18:10 at com.google.android.fhir.datacapture.test.QuestionnaireUiEspressoTest$dateTimePicker_shouldSetAnswerWhenDateAndTimeAreFilled$1.invokeSuspend(QuestionnaireUiEspressoTest.kt:255)

This has been noticed e.g. in #2471, and it's now also blocking merging #2463 to fix #2237, which in turn is holding up #2483.

Component Datacapture

To Reproduce Raise a PR and it Kokoro fails due to something unrelated to what you are working on .

Expected behavior Tests which are unrelated to the current change must always pass.

Would you like to work on the issue? I'll see if I propose a PR to disable (ignore) that test.

I don't want to work on fixing that test - but perhaps someone else is interesting in picking this up?