search

google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
458 stars 238 forks source link

Support both 12h *AND* 24h in flaky dateTimePicker_shouldSetAnswerWhenDateAndTimeAreFilled test (fixes #2485) #2487

Closed vorburger closed 2 months ago

vorburger commented 2 months ago

fixes #2485

If it works - I typed this in GitHub's web editor, not a real IDE, so I'm not sure this will even compile... 🤣

vorburger commented 2 months ago

If it works - I typed this in GitHub's web editor, not a real IDE, so I'm not sure this will even compile... 🤣

Apparently I'm still too stupid for Kt?

assertThat(isOK).withMessage​("expected: %s OR %s but was: %s", dateTime12, dateTime24, answer)

fails to compile due to:

Unexpected tokens (use ';' to separate expressions on the same line)

Why? I'll just simplify it to only assertThat(isOK) (without message), for now.

vorburger commented 2 months ago

2489 was a better Fix for that problem than this, so closing this in favour of that one (which I've just merged).