google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
458 stars 238 forks source link

Mark many things as internal #2494

Open williamito opened 1 month ago

williamito commented 1 month ago

Description Mark many things as internal, as they don't seem to be used by any public API. This will significantly streamline generated documentation.

Type Code Health

Screenshots (if applicable)

Checklist

williamito commented 1 month ago

Switching to draft, I'm finding a lot of other things that appear to be safely marked internal

santosh-pingle commented 1 month ago

@santosh-pingle can you run the demo app and just check that the db is functioning as expected (don't need to spend too much time)

@aditya-07 in case you spot anything wrong here.

thanks @williamito this is fine by me as long as tests pass - nothing glaringly wrong to me.

After this pull request was updated with the latest code changes (PR#2497), the upload sync was working fine, and the database was not throwing any exceptions.

jingtang10 commented 1 month ago

thanks so much santosh for testing!