google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
458 stars 238 forks source link

Add initial new website (see #2232) #2513

Closed vorburger closed 1 week ago

vorburger commented 1 month ago

see #2232

vorburger commented 2 weeks ago

I've finally had a moment to have a closer look into why as-is this "works for me" (local), but initially fails the CI build:

It's because build-docs.bash uses a pipenv - which is not available by default in GitHub Runner VM images, apparently.

I could just add https://pipenv.pypa.io/en/latest/installation.html to build-docs.bash ... or is there a ready-made action?

Looking around a bit, discarding a few repos with 0 stars, I have zoomed in on:

  1. https://github.com/tiagovrtr/actions-pipenv
  2. https://github.com/VaultVulp/action-pipenv
  3. https://github.com/palewire/install-python-pipenv-pipfile

Of these, the last one (@palewire's) does both Python & PipEnv, and seem to do some caching; so I'll try to add that...

vorburger commented 2 weeks ago

https://github.com/palewire/install-python-pipenv-pipfile didn't seem to immediately just work, see https://github.com/palewire/install-python-pipenv-pipfile/issues/7, so 'm trying https://github.com/tiagovrtr/actions-pipenv instead, let's see...

vorburger commented 2 weeks ago

I'm trying https://github.com/tiagovrtr/actions-pipenv instead, let's see...

That seems to work better, but pipenv run mkdocs build now fails with:

Warning: Python 3.11 was not found on your system...
Neither 'pyenv' nor 'asdf' could be found to install Python.
You can specify specific versions of Python with:
$ pipenv --python path/to/python
Error: Process completed with exit code 1.

so trying Python 3.11 instead of latest 3.12 which I've initially selected (whatever works).

vorburger commented 2 weeks ago

so trying Python 3.11 instead of latest 3.12 which I've initially selected (whatever works).

That helped! Plus adding a missing install - I must have done that locally, but CI needs to explicitly do it as well, of course.

With that, this is ready for review! https://google.github.io/android-fhir/ should look very different after this is merged...