google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
458 stars 238 forks source link

#2503 push SNAPSHOT Maven artifacts to github Packages #2525

Open icrc-fdeniger opened 3 weeks ago

icrc-fdeniger commented 3 weeks ago

Fixes #2503

Description Publish Maven artifacts in GitHub Packages

Type Feature

Checklist

Versions

Suggestion/question why not removeing beta/alpha as versions like 0.X.Y are considered as development version ?

Current Version Used in this PR Proposition
common:0.1.0-alpha05 common:0.1.0-alpha06 common:0.1.1
engine:1.0.0 engine:1.0.1 engine:1.0.1
data-capture:1.1.0 data-capture:1.1.1 data-capture:1.1.1
workflow:0.1.0-alpha04 workflow:0.1.0-alpha05 workflow:0.1.1
ontrib-barcode:0.1.0-beta3 ontrib-barcode:0.1.0-beta4 ontrib-barcode:0.1.1
contrib-locationwidget:0.1.0-alpha01 contrib-locationwidget:0.1.0-alpha02 contrib-locationwidget:0.1.1
knowledge:0.1.0-alpha03 knowledge:0.1.0-alpha04 knowledge:0.1.1

if a dev Team wants to use an alpha/beta version it can use a dependency to a SNAPSHOT version ( the "unstable version created from the last build"). it's also possible to specify the artifact of a build with by example: engine-1.0.1-20240423.083712-3

icrc-fdeniger commented 1 week ago

Hello @santosh-pingle, @ktarasenko please tell me if this PR need to be modified. I understand that the version updates are the "tricky" part and will be happy to modify this. My point was to update them to the next version as GitHub Actions should produce SNAPSHOT of next versions.

Thanks

vorburger commented 1 week ago

@icrc-fdeniger FYI the artifact version number changes introduced here will cause build failures once you rebase this after #2533 is merged. The required fix (after you have rebased it, not right now) is as simple as changing those version numbers also in the (new, TBD) docs/use/api.md file; hopefully that's trivial. Please do shout if unclear!

@MJ1998 @santosh-pingle @ktarasenko merge this only after #2533.

icrc-fdeniger commented 1 week ago

@vorburger @santosh-pingle @ktarasenko should be ok now

vorburger commented 1 week ago

@vorburger @santosh-pingle @ktarasenko should be ok now

LGTM! I say let's merge this... @santosh-pingle @ktarasenko @MJ1998 no objects, right?

MJ1998 commented 4 days ago

Thanks for this PR @icrc-fdeniger. LGTM.

About the version proposal we would wanna keep the alpha/beta naming conventions. Reason - Using alpha and beta suffixes aligns with established conventions in semantic versioning and open-source software development. So we would like to stick with it.