search

google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
465 stars 246 forks source link

Autoassign android-fhir-reviewers@ instead of all of android-fhir@ as reviewers of PRs #2536

Closed vorburger closed 1 month ago

vorburger commented 1 month ago

Fixes #2320

vorburger commented 1 month ago

Unknown owner on line 2: make sure the team @google/android-fhir-reviewers exists, is publicly visible, and has write access to the repository @google/android-fhir-reviewers

@omarismail94 it says that you are the Maintainer of https://github.com/orgs/google/teams/android-fhir-reviewers - would you be able to make it publicly visible and ensure its members have write access to this repo? (Perhaps you could even make it a child team of https://github.com/orgs/google/teams/android-fhir ?)

vorburger commented 1 month ago

Unknown owner on line 2: make sure the team @google/android-fhir-reviewers exists, is publicly visible, and has write access to the repository @google/android-fhir-reviewers

Pro Memoria: This error message, somewhat confusingly, does NOT appear as a (green) "Check", but is only visible directly in the Files changed tab on the CODEOWNERS diff.

@omarismail94 it says that you are the Maintainer of https://github.com/orgs/google/teams/android-fhir-reviewers

@omarismail94 has removed himself and made me a co-Maintainer of https://github.com/orgs/google/teams/android-fhir-reviewers, so I now have access to https://github.com/orgs/google/teams/android-fhir-reviewers/edit (but not to https://github.com/orgs/google/teams/android-fhir and https://github.com/orgs/google/teams/android-fhir-1).

would you be able to make it publicly visible

That's the case now, https://github.com/orgs/google/teams/android-fhir-reviewers/edit says that @android-fhir-reviewers has "Team visibility: Visible (Recommended) = A visible team can be seen and @mentioned by every member of this organization."

and ensure its members have write access to this repo?

Neither https://github.com/google/android-fhir/settings nor https://github.com/orgs/google/teams/android-fhir-reviewers/edit directly allowed me to that. I think we would have to add google/android-fhir to https://github.com/orgs/google/teams/android-fhir-reviewers/repositories... ?

vorburger commented 1 month ago

I think we would have to add @google/android-fhir to https://github.com/orgs/google/teams/android-fhir-reviewers/repositories... ?

No, a better option than doing it like that is actually to make @google/android-fhir-reviewers a child team of @google/android-fhir ... I can and just did do this; this granted the @google/android-fhir-reviewers the Maintain role for https://github.com/google/android-fhir/ and the Write role for https://github.com/google/fhir-app-examples (just like all members of @google/android-fhir) have - which (to me) makes perfect sense!

Team was successfully updated. The requested parent team will be reflected pending approval.

@jingtang10 is currently the only Maintainer of @google/android-fhir, and would need to approve that request... until he has a chance to do so, I've (for at least temporarily) attempted to after all manually directly add @google/android-fhir to https://github.com/orgs/google/teams/android-fhir-reviewers/repositories... but I can't do that either, because "Only repositories that you have admin privileges for can be added."... 🤣

PS: Just FTR, for some reason there is both a @google/android-fhir and a @google/android-fhir-1 group; I've used the former here, and ignored the latter. (They both have the same members, currently - the -1 one says TeamSync managed team - whatever that means.)

vorburger commented 1 month ago

I'm planning to close this PR in favour of https://github.com/google/android-fhir/pull/2545 if we merge that one...