add DE resources for localization

kedegger-ait commented 1 month ago

https://github.com/google/android-fhir/issues/499

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description Clear and concise code change description.

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Screenshots (if applicable)

Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[ ] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jingtang10 commented 3 weeks ago

hi @kedegger-ait! thanks for the contribution. is this something you need in your application?

as it stands we encourage applications to include resources in their own codebase instead of adding languages in the library resources. it's because we cannot really take on the task of maintaining up-to-date translations for all languages. this is simply too big a task and it's something much better suitable for each application.

as an app developer you can simply override these resources in your own resource folders and i think it'll just work as intended when the user chooses that language.

i'll close this pr for this reason. but please reopen if you have a particular reason for this to be included.

we will be very pleased if you would like to further contribue to the library - but if you can please try to comment on issues first to reach agreement with code maintainers / reviewers to avoid duplicate / unnecesssary work!

thanks again! - jing

kedegger-ait commented 3 weeks ago

Hi Jing Tang,

thank you for your message. I wasn’t aware of the i18n policy in this library and thought I might help by sharing my translations to the codebase of the FHIR library.

We have already added the respective translations to our resource folders, but thank you for pointing out this solution. If I might add one minor remark to the situation: For the policy to add translations to the project resource folders instead of managing them within the library, it might avoid conflicts with other project resources if the resource names are specific to the library (e.g. avoid very generic names like ‘help’ or ‘save’).

But these are just my 2 cents.

Best regards and thank you and the other collaborators for providing this great library!

Thank you again and my apologies if I caused unnecessary work.

K.

google / android-fhir

add DE resources for localization #2551