search

google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
481 stars 253 forks source link

Reenable workflow test #2638

Open jingtang10 opened 1 month ago

jingtang10 commented 1 month ago

Describe the bug A number of workflow library tests have been disabled in https://github.com/google/android-fhir/pull/2637 as a result of the upgrade the clinical reasoning dependencies from 3.0 prerelease to 3.8.

Some are results of our test code no longer doing the right thing (for example mixing urls with verions), but we also need to rethink how deep we want to test the clinical reasoning module -- we want to make sure it works on android, but i'm not sure we need to check that every single code path is executed and tested. It's not realistic, and not necessary. We need to make sure our test cases are typical, cover the "happy paths" and are easy to maintain.

Additionally, some of these tests probably should be moved to clinical reasoning codebase.

So we probably want to fix some of these tests, but also retire some of these tests that we no longer think are useful.

Component Workflow lib

To Reproduce Run the tests

Expected behavior

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information): NA

Additional context Add any other context about the problem here.

Would you like to work on the issue? Please state if this issue should be assigned to you or who you think could help to solve this issue.

jingtang10 commented 1 month ago

@vitorpamplona @delcroip @brynrhodes