google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
495 stars 296 forks source link

Parse the DateType value in the demo app. #2723

Open santosh-pingle opened 1 week ago

santosh-pingle commented 1 week ago

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2720

Description The demo app crashed when LocalDate parsing was attempted on valueString of DateType (e.g., '1966'). Fix: LocalDate is now parsed from DateType.value instead of valueString.

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type Choose one: Bug fix

Screenshots (if applicable)

Checklist

MJ1998 commented 1 week ago

What is the issue with

LocalDate parsing was attempted on valueString of DateType (e.g., '1966').

?

santosh-pingle commented 1 week ago

What is the issue with

LocalDate parsing was attempted on valueString of DateType (e.g., '1966').

? its partial date value.