google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
493 stars 294 forks source link

After selecting Temperature unit as Fahrenheit, it is showing minimum and maximum range of Celsius #876

Open anita-vadverao opened 3 years ago

anita-vadverao commented 3 years ago

Describe the bug After selecting Temperature unit as Fahrenheit, it is showing minimum and maximum range of Celsius

Component Core library, SDC library, reference app

Precondition Patient is already added

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Reference App'
  2. Search for patient already added in precondition
  3. Tap On Patient name
  4. On patient Card, Tap on

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information): Device: Lenovo Tab Android version: 10 Build number: TB-8505X-S320017_210427_BMP

anita-vadverao commented 3 years ago

For Risk Factor, covid Vaccination it is showing that it is mandatory field but without entering any data in these fields, able to submit complete survey.

epicadk commented 3 years ago

Related to #881. If we do want to support minValue and maxValue extensions for questions like the one mentioned in the issue, we'll need to use the unit converter during validation, However I am not sure whether this is in line with the spec.