Read only view in questions/forms are too light.

[santosh-pingle]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Issue #917

Description

• Override default theme text color to improve contrast of disabled text. android:textColor
• Override default theme box stroke color to improve contrast of disabled widget. boxStrokeColor

Alternative(s) considered Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type Choose one: Feature

Screenshots (if applicable)

Before implementation Edit text with Mark value

After implementation Edit text with Mark value

Checklist

• [x] I have read and acknowledged the Code of conduct
• [x] I have read How to Contribute
• [x] I have read the Developer's guide
• [x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
• [x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
• [x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
• [x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
• [x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

[santosh-pingle]

@jing could you please confirm proposed implementation?

[codecov[bot]]

Codecov Report

Merging #939 (f6635cb) into master (a0e522e) will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #939      +/-   ##
============================================
- Coverage     88.33%   88.29%   -0.04%     
  Complexity      491      491              
============================================
  Files           111      111              
  Lines          9335     9340       +5     
  Branches        636      641       +5     
============================================
+ Hits           8246     8247       +1     
+ Misses          751      750       -1     
- Partials        338      343       +5     

Impacted Files	Coverage Δ
.../QuestionnaireItemAutoCompleteViewHolderFactory.kt	26.89% <0.00%> (-0.19%)	:arrow_down:
...ws/QuestionnaireItemDatePickerViewHolderFactory.kt	35.71% <0.00%> (-0.52%)	:arrow_down:
...uestionnaireItemDateTimePickerViewHolderFactory.kt	22.22% <0.00%> (-0.39%)	:arrow_down:
...iews/QuestionnaireItemEditTextViewHolderFactory.kt	45.45% <0.00%> (-1.43%)	:arrow_down:
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt	90.12% <0.00%> (+1.23%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0e522e...f6635cb. Read the comment docs.

[jingtang10]

please also update the PR name and description

[santosh-pingle]

Updating code changes as per review comments.

[jingtang10]

please mark as ready to review if ready. thanks!

[santosh-pingle]

@jingtang10 Implemented contrast change is only visible to questionnaire edit text view (QuestionnaireItemEditTextViewHolderFactory) and not for others. Do we need to apply it to other questionnaire views?

[jingtang10]

@jingtang10 Implemented contrast change is only visible to questionnaire edit text view (QuestionnaireItemEditTextViewHolderFactory) and not for others. Do we need to apply it to other questionnaire views?

yeah you do. anything with the edit text you'll need to apply the stroke color, anything with text you'll probably need to apply the text color.

[jingtang10]

have you also tested this with dark theme? please attach some screenshots. thanks!

[jingtang10]

also please attach before/after screenshots with other widgets (e.g. radio button group, checkbox group) if you do them in the same PR.

[santosh-pingle]

have you also tested this with dark theme? please attach some screenshots. thanks!

looking into it.

[santosh-pingle]

have you also tested this with dark theme? please attach some screenshots. thanks!

looking into it.

@shelaghm when #9E9E9E get applied to the disabled text and container it works as expected in light theme (please refer earlier screenshots) but when it switch to the dark theme then contrast/opacity is too high. To fix this issue, it is required to use alpha value and theme attribute to create color state list resource. As you mentioned 38% opacity in earlier comments I assumed alpha value is .38 as range is 0 to 1, now it works in both themes, but if you think alpha value can be greater than .38 please let me know.

Light theme : read only view with alpha .38

Dark theme : readonly view with alpha .38

Just for reference text color with alpha .45 and container border stroke color with alpha .38

[santosh-pingle]

Q.4 readonly autocomplete textview, light theme, alpha .38

Q.4 readonly autocomplete textview, dark theme, alpha .38

[santosh-pingle]

Q Hep B y / n readonly view QuestionnaireItemBooleanTypePickerViewHolderFactory, alpha .38, light theme

Q Hep B y / n readonly view QuestionnaireItemBooleanTypePickerViewHolderFactory, alpha .38, dark theme

[santosh-pingle]

Q. 1st dose 2nd dose readonly view QuestionnaireItemDateTimePickerViewHolderFactory, light theme, alpha .38

Q. 1st dose 2nd dose readonly view QuestionnaireItemDateTimePickerViewHolderFactory, dark theme, alpha .38

[santosh-pingle]

Q.1 & Q.3 readonly view QuestionnaireItemDialogSelectViewHolderFactory, light theme, alpha .38

Q.1 & Q.3 readonly view QuestionnaireItemDialogSelectViewHolderFactory, dark theme, alpha .38

[santosh-pingle]

@jingtang10 Can you please review it? Thanks!

[santosh-pingle]

readonly view QuestionnaireItemDropDownViewHolderFactory alpha .38

[santosh-pingle]

readonly view QuestionnaireItemCheckBoxGroupViewHolderFactory alpha .38

[anita-vadverao]

Retested "Readonly" changes by adding "readOnly" : true" attribute in Questionnaire JSON and it is properly visible after adding contrast to text. Working as expected.