google / android-fhir

The Android FHIR SDK is a set of Kotlin libraries for building offline-capable, mobile-first healthcare applications using the HL7® FHIR® standard on Android.
https://google.github.io/android-fhir/
Apache License 2.0
498 stars 296 forks source link

Sdc gallery app boolean choice component workflow #992

Closed santosh-pingle closed 2 years ago

santosh-pingle commented 2 years ago

Is your feature request related to a problem? Please describe.

  1. Design boolean choice questionnaire json without required fields. (error message will not be shown as field is not mandatory)
  2. Api to retrieve single choice questionnaire json from model view.
  3. Handle single choice item click
  4. Implement questionnaire fragment and model view to show questionnaire json
  5. Show action bar, update title as per screen, align title text.
  6. Update color palette hex codes.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Would you like to work on the issue? Please state if this issue should be assigned to you or who you think could help to solve this issue.

santosh-pingle commented 2 years ago

Continuing implementation ...

santosh-pingle commented 2 years ago

@shelaghm Sdc library has two views which support a single choice component (radio button).

I am thinking of having 2 separate single choice components for choice and boolean type in the components list and separate workflow. Is it okay? (if yes then I will create separate issue to implement it.)

cc @jingtang10 @aditya-07

shelaghm commented 2 years ago

@santosh-pingle this makes sense to me to show both options as separate components. Please create a new githib issue and tag me.

Based on this I'll create a new icon for the Boolean choice and will use different example content for the two different components. I'll update the figma file to reflect this.

santosh-pingle commented 2 years ago

@shelaghm Thanks for sharing color palette! Can you please also share color PrimaryVariant and color SecondaryVariant color hex code.

shelaghm commented 2 years ago

@santosh-pingle Decided we will not use PrimaryVariant and color SecondaryVariant color. Just posting it here so we close the loop on the decision.