google / ansicolor-dart

Apache License 2.0
104 stars 26 forks source link

Explicitly Enable Strong Mode Analysis #12

Closed bencampbell-wf closed 7 years ago

bencampbell-wf commented 7 years ago

Enabling Strong Mode analysis ensures that the package is compatible with the Dart Dev Compiler. By maintaining a the analysis_options.yaml file it is possible for tooling to audit strong mode compliance throughout the dependency graph of a dart application.

The implementation is currently strong mode complaint and requires no code changes:

dartanalyzer --verbose --fatal-infos --fatal-warnings lib/ansicolor.dart test/ansicolor_test.dart
Analyzing lib/ansicolor.dart, test/ansicolor_test.dart...
Loaded analysis options from /tmp/ansicolor-dart/analysis_options.yaml
No issues found!
googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jtmcdole commented 7 years ago

Did you mean to close this?

bencampbell-wf commented 7 years ago

@jtmcdole I did. The change was introduced with respect to a strong mode audit. I determined it was unnecessary.