google / ansicolor-dart

Apache License 2.0
104 stars 26 forks source link

Upgrade to null_safety #21

Closed renatoathaydes closed 3 years ago

renatoathaydes commented 3 years ago

Hey, I thought you might want to publish your package with null_safety support.

I did the migration for you and incredibly, all your code was already null safe 👍 .

So all I had to do was change the pub spec and release notes.

You can check that I've followed the instructions given by the Dart docs: https://dart.dev/null-safety/migration-guide

As I have a package that depends on your package, I would appreciate if you could publish this version.

Thanks in advance!

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹī¸ Googlers: Go here for more info.

renatoathaydes commented 3 years ago

I've signed the CLA now... hopefully the check will pass soon.

jtmcdole commented 3 years ago

I don't know how to restart the CLA check. I think you have to just push something to the change?

jtmcdole commented 3 years ago

I ran the tool myself and did some tweaks. I'll upgrade the package today with the tool results.

renatoathaydes commented 3 years ago

I pushed a typo fix just in case :)

jtmcdole commented 3 years ago

I've

Thanks for the suggestion / push to officially support nullsaftey, Renato!