search

google / ansicolor-dart

Apache License 2.0
104 stars 26 forks source link

Add public color getters to AnsiPen #29

Closed Frezyx closed 12 months ago

Frezyx commented 12 months ago

Hello @jtmcdole 👋 I need to determine the current color configuration set of AnsiPen in my logger package talker (that package uses ansicolor for colorful console logs)

However, the _fcolor, _bcolor, and _dirty is private fields. Is it possible to provide external access to retrieve this information using getters?

google-cla[bot] commented 12 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jtmcdole commented 12 months ago

I don't have a problem with this pull request (A+ on using getters).. Can you sign the CLA so I can merge?

Frezyx commented 12 months ago

I'm already signed the CLA

image
jtmcdole commented 12 months ago

updated to 2.0.2: https://pub.dev/packages/ansicolor/versions