search

google / ansicolor-dart

Apache License 2.0
104 stars 26 forks source link

Reconcile top-level field names with style guide #3

Closed seaneagan closed 4 years ago

seaneagan commented 9 years ago

https://www.dartlang.org/articles/style-guide/#prefer-using-lowercamelcase-for-constant-names

color_disabled is the biggest offender since it's not a constant, the others are a recent change to the style guide, which I'm not sure the entire dart community is aware of or in agreement with (but I personally am).

jtmcdole commented 9 years ago

I personally hate ALL CAPS for consts. I can touch up the fields and leave the old ones with @deprecated