search

google / arb-editor

A VS Code extension to help with .arb files used for translation messages in software.
https://marketplace.visualstudio.com/items?itemName=Google.arb-editor
Apache License 2.0
48 stars 7 forks source link

Allow decimalPatternDigits number format #47

Closed slaci closed 1 month ago

slaci commented 7 months ago

According to https://localizely.com/flutter-arb/ Flutter supports decimalPatternDigits as a number formatter in arb files. However, this plugin does not list that as a valid options in the JSON schema, so a warning with the label "Value is not accepted." is shown in the Problems panel in Vscode when the arb file contains this formatter name.

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

amal-stack commented 2 months ago

It would be great if this minor change were merged soon. The warning when using decimalPatternDigits is so annoying. If not, please suggest a way to suppress this warning. For some reason, adding:

"arbEditor.suppressedWarnings": [
        "all"
    ],

does not work either.

mosuem commented 2 months ago

It would be great if this minor change were merged soon.

Please refile this PR, as we can't accept contributions without a CLA. Otherwise I will put refiling it on my to-do list :)

slaci commented 2 months ago

It would be great if this minor change were merged soon.

Please refile this PR, as we can't accept contributions without a CLA. Otherwise I will put refiling it on my to-do list :)

Hello @mosuem

Please refile this, I'm not planning to sign the CLA for this one line of code.

Thank you,

mosuem commented 1 month ago

Fixed by #55