google / archive-patcher

Automatically exported from code.google.com/p/archive-patcher
Apache License 2.0
534 stars 74 forks source link

Is this lib production ready or deprecated? #162

Open fzyzcjy opened 3 years ago

fzyzcjy commented 3 years ago

Hi thanks for the lib! I wonder whether this lib is ready to be used in production environment, or it is already deprecated (seems nobody is maintaining it...)? Thanks!

pspencil commented 3 years ago

Hi, this lib is stable under the following assumptions:

On Wed, Dec 23, 2020, 03:35 fzyzcjy notifications@github.com wrote:

Hi thanks for the lib! I wonder whether this lib is ready to be used in production environment, or it is already deprecated (seems nobody is maintaining it...)? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/archive-patcher/issues/162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYQENYGHDRU6ZOCOD2U4ODSWFQQZANCNFSM4VGOTWPQ .

fzyzcjy commented 3 years ago

@pspencil Thanks! Sorry I am a bit confused: What is "native libraries"? IMHO this github repo only has java code...

pspencil commented 3 years ago

Look inside this dir. https://www.github.com/google/archive-patcher/tree/v2/generator%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Farchivepatcher%2Fgenerator%2Fbsdiff%2Fwrapper

It uses the native bsdiff implementation. The java version should also work. But it is just slower (and not used for a long time so not the same guarantees)

fzyzcjy commented 3 years ago

@pspencil Ha interesting! So how do I use that instead of the java one? You mentioned that I cannot use gradle to build it. Thank you!

andrewhayden commented 3 years ago

I can no longer speak for the team on this, but the pure-java version in tag "1.0 " (https://github.com/google/archive-patcher/releases/tag/1.0) is quite stable. Depending on your use case, the performance may / may not be a problem. I'd personally (again not speaking for the team here) encourage you to try it out and see if its performance is adequate to your needs.

fzyzcjy commented 3 years ago

@andrewhayden Thank you very much! I have downloaded https://dl.bintray.com/juliantoledo/Maven/archive-patcher-1.0.jar several hours ago, and that speed (>10 seconds) is acceptable for me though a little bit slow.

fzyzcjy commented 3 years ago

@pspencil @andrewhayden By the way, a curious question: Does Google Play uses this for downloading app? If so, that sounds awesome!

pspencil commented 3 years ago

Yes it is one of the options.

pauloavelar commented 3 years ago

Hello. Let me piggyback this issue because the question relates to the production-readiness of the library.

Is there a release plan for v2? I see commits being synced recently and the new generateDelta interface with ByteSource instead of File is something I could really use.