google / asylo

An open and flexible framework for developing enclave applications
https://asylo.dev
Apache License 2.0
973 stars 126 forks source link

Fix asylo_redis example documentation #32

Closed ghost closed 5 years ago

ghost commented 5 years ago

The asylo_redis readme instructions are not working.

This PR updates the readme instructions for configuring WORKSPACE and BUILD file

KeithMoyer commented 5 years ago

Again, sorry you didn't get a response on your PR. :-(

The @com_google_asylo prefixes show up correctly when exported to our website and examples repo due to our tooling, so we missed it that it wasn't right in the README.md here.

Reopening.

ghost commented 5 years ago

Ah, I closed the PR after looking at the announcement of Asylo 0.4.0.

Since it seemed like Redis example is (somehow) going to be updated , i thought this PR would be obsolete ;)

newgrp commented 5 years ago

Thank you for your contribution @shpark!