search

google / authenticode-rs

Rust tools for working with Authenticode
Apache License 2.0
26 stars 9 forks source link

Error handling for AttributeCertificateIterator #31

Closed N0fix closed 1 year ago

N0fix commented 1 year ago

PR for issue #29 adding error handling for AttributeCertificateIterator. Basically checks bounds for reads, and throws AttributeCertificateError::OutOfBounds when needed.

codecov-commenter commented 1 year ago

Codecov Report

Merging #31 (03012af) into main (8015364) will decrease coverage by 1.06%. The diff coverage is 76.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   87.23%   86.18%   -1.06%     
==========================================
  Files           7        7              
  Lines         478      485       +7     
==========================================
+ Hits          417      418       +1     
- Misses         61       67       +6
Files Coverage Δ
authenticode-tool/src/main.rs 93.54% <100.00%> (+0.17%) :arrow_up:
authenticode/src/win_cert.rs 82.02% <64.70%> (-6.35%) :arrow_down:
N0fix commented 1 year ago

Thanks for the reviews !