search

google / auto

A collection of source code generators for Java.
Apache License 2.0
10.4k stars 1.2k forks source link

Conflict with dependency 'com.google.guava:guava' #447

Open dlbock opened 7 years ago

dlbock commented 7 years ago

v1.0-beta4 still depends on guava-v19.0, which creates a conflict with robolectric v >= 3.2.2 that uses guava-v20.0. The latest version of guava is v21.0. Is there a plan to upgrade the guava dependency soon?

ronshapiro commented 7 years ago

@eamonnmcmanus do we want all auto processors to support the same version of javac? If not, I'm happy to upgrade AutoFactory to use Guava 21 and javac8. Otherwise, at least in the meantime we can do Guava 20 and still support javac6

JakeWharton commented 7 years ago

This is not a conflict, though. Guava is designed to handle these versions skews in a binary compatible way so long as you're within the upgrade window which all three of those versions are.

On Mon, Mar 13, 2017, 1:54 PM Dahlia B. notifications@github.com wrote:

v1.0-beta4 still depends on guava-v19.0, which creates a conflict with robolectric v >= 3.2.2 that uses guava-v20.0. The latest version of guava is v21.0. Is there a plan to upgrade the guava dependency soon?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/auto/issues/447, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEQnA4jHH-Lra8x-7SpXGBYjUJSaiks5rlYLcgaJpZM4Mbmol .

eamonnmcmanus commented 7 years ago

I'm planning to switch AutoValue to requiring javac8 fairly soon (while still outputting javac6-compatible source code). Meanwhile, I don't think there's a strong requirement for the different auto-* projects to use the same Guava version.

kluever commented 4 years ago

Did the switch ever happen?