search

google / automl

Google Brain AutoML
Apache License 2.0
6.18k stars 1.45k forks source link

p.add_(..., inplace=True) error #1201

Open markussteindl opened 8 months ago

markussteindl commented 8 months ago

commit: c7392f2bab3165244d1c565b66409fa11fa82367 line: automl/lion/lion_pytorch.py:81

When calling Lion.step(), I get this error message:

TypeError: add_() received an invalid combination of arguments - got unrecognized keyword arguments: inplace

I think p.add_() is already the inplace version, while p.add() has an optional parameter inplace.
Or am I using the wrong pytorch version? I have 2.0.1+cu118.

fbotp commented 8 months ago

@Stonatus I found some info about Tensor.add_ method in pytorch document, and it means add_ is an inplace method, so I think it might be okey to just remove inplace argument in line: automl/lion/lion_pytorch.py:81, and it seems work fine