search

google / automotive-design-compose

Automotive Design for Compose is an extension to Jetpack Compose that allows every screen, component, and overlay of your Android App to be defined in Figma, and lets you see the latest changes to your Figma design in your app, immediately!
https://google.github.io/automotive-design-compose/
Apache License 2.0
101 stars 14 forks source link

Closes #982: Fix JSON generation when using design modules #1004

Closed rylin8 closed 3 weeks ago

github-actions[bot] commented 1 month ago

Snapshot diff report vs base branch: main Last updated: Thu Apr 11 22:22:16 PDT 2024, Sha: e8a3ca9a621aa0df5db7f39fa9f3871b16ca10e9 No differences detected

rylin8 commented 1 month ago

I had to again add temporary annotations @DesignContentTypesProperty and @DesignPreviewContentProperty to support using these in module classes. This is getting a bit out of hand due to the KSP bug. @timothyfroehlich have you looked into KSP2 at all? That might fix the bug, but I'm not sure what it takes to switch to it. https://android-developers.googleblog.com/2023/12/ksp2-preview-kotlin-k2-standalone.html

timothyfroehlich commented 1 month ago

I had to again add temporary annotations @DesignContentTypesProperty and @DesignPreviewContentProperty to support using these in module classes. This is getting a bit out of hand due to the KSP bug. @timothyfroehlich have you looked into KSP2 at all? That might fix the bug, but I'm not sure what it takes to switch to it. https://android-developers.googleblog.com/2023/12/ksp2-preview-kotlin-k2-standalone.html

Not yet, but I'm happy to if Ralph gives me the go ahead.