google / automotive-design-compose

Automotive Design for Compose is an extension to Jetpack Compose that allows every screen, component, and overlay of your Android App to be defined in Figma, and lets you see the latest changes to your Figma design in your app, immediately!
https://google.github.io/automotive-design-compose/
Apache License 2.0
101 stars 14 forks source link

Check size of stops of gradient background #1036

Closed yiqunw700 closed 2 weeks ago

yiqunw700 commented 2 weeks ago

Figma is returning empty stops for gradients. Gradients can also have a single stop set. Also add logging when size is smaller than 2.

github-actions[bot] commented 2 weeks ago

Snapshot diff report vs base branch: main Last updated: Wed Apr 24 16:25:08 PDT 2024, Sha: ccaf70e561b9fc463282f61de3594b74e590ca8c No differences detected

rylin8 commented 2 weeks ago

Looks good! Thanks for fixing this quickly! I would test it but my machine is not setup fully yet.

rylin8 commented 2 weeks ago

Finally have a semi-working machine. Built this, and found that even HelloWorld's gradient is broken :(. Hope Figma fixes this soon. If we were to update our .dcf files, I think all tests with gradients would change. Screenshot 2024-04-24 at 11 22 26 PM